For everybody's sanity, I will go ahead and spell out the rule of grammar:

"If you're selling something, it's for sale; but if you lower the price, it goes on sale."

So, unless you have listed an item and are revising the price and thus lowering it down, it is FOR SALE, not ON SALE.