I also watched that classic between sampras and agassi.  but at 26 with 12 grandslam titles, i think federer is best ever.  look at his consistency, he's been no 1 for a long time now.  he has dominated tennis for a long time.